Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize prerelease website #66

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ramereth
Copy link
Contributor

This will allow the OSL to manage this as a docker container and handle updates
better in the long term. Some key changes:

  • Add weekly dependabot checks
  • Add requirements.txt
  • Add basic CI
  • Build and release container images on ghcr.io which will be used in the
    cookbook
  • Do a weekly build regardless of any dependabot bumps
  • Deploy website using gunicorn instead of mod_python
  • Create wsgi.py for gunicorn

Signed-off-by: Lance Albertson [email protected]

nuclearsandwich added a commit that referenced this pull request Jun 24, 2024
Required since I don't know how to initiate GitHub Actions without having a workflow defined on the default branch.
@nuclearsandwich
Copy link
Contributor

I bootstrapped GitHub Actions on the default branch but that hasn't given me the Actions popup in this PR to allow new contributors. I've relaxed that setting for now so hopefully a subsequent push will be enough to kick that off without an additional review. If it doesn't, we might have to split the PR into adding the workflow knowing it will fail, and then fixing up the workflow.

@ramereth ramereth force-pushed the dockerize branch 4 times, most recently from 3bc6a0e to 7d11e5d Compare June 24, 2024 20:21
@ramereth
Copy link
Contributor Author

@nuclearsandwich for some reason I can't get the ci.yml job to run. Any ideas why that might be?

@nuclearsandwich
Copy link
Contributor

nuclearsandwich commented Jun 24, 2024

@nuclearsandwich for some reason I can't get the ci.yml job to run. Any ideas why that might be?

Actions was added to GitHub after I left the company so I have no leftover insights.
My only guess is that Actions were not enabled on the default branch when the PR was added or that the specific workflow file isn't part of the default branch.

@nuclearsandwich
Copy link
Contributor

Closing and re-opening the PR appears to have kicked that which needed kicking.

This will allow the OSL to manage this as a docker container and handle updates
better in the long term. Some key changes:

- Add weekly dependabot checks
- Add requirements.txt
- Add basic CI
- Build and release container images on ghcr.io which will be used in the
  cookbook
- Do a weekly build regardless of any dependabot bumps
- Deploy website using gunicorn instead of mod_python
- Create wsgi.py for gunicorn

Signed-off-by: Lance Albertson <[email protected]>
@ramereth
Copy link
Contributor Author

@nuclearsandwich oh well, if this looks good, please go ahead and merge so that I can test the deployment side of it.

- master
pull_request:
schedule:
- cron: '45 18 * * 3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6:45PM on Wednesday.

--error-logfile '-' \
--log-file "-" \
--access-logformat '%({x-forwarded-for}i)s %(h)s %(l)s %(u)s %(t)s "%(r)s" %(s)s %(b)s "%(f)s" "%(a)s"' \
--forwarded-allow-ips="140.211.9.104,2605:bc80:3010:104::8cd3:968" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may send a follow-up PR that breaks these values out into a variable so they can be described in a comment for future me who forgets what these IPs are.

@nuclearsandwich nuclearsandwich merged commit 1406f13 into ros-infrastructure:master Jun 24, 2024
1 check passed
@ramereth ramereth deleted the dockerize branch June 24, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants